From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25396 invoked by alias); 15 Mar 2011 15:45:35 -0000 Received: (qmail 25252 invoked by uid 22791); 15 Mar 2011 15:45:30 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SARE_BAYES_5x7,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Mar 2011 15:45:09 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2FFj7Ma019775 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 15 Mar 2011 11:45:07 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p2FFj7RV016957; Tue, 15 Mar 2011 11:45:07 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p2FFj6MG019164; Tue, 15 Mar 2011 11:45:06 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 02054378CA1; Tue, 15 Mar 2011 09:45:05 -0600 (MDT) From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] Fix empty PC range psymtab<->symtab discrepancy References: <20110314175625.GA29782@host1.jankratochvil.net> Date: Tue, 15 Mar 2011 15:51:00 -0000 In-Reply-To: <20110314175625.GA29782@host1.jankratochvil.net> (Jan Kratochvil's message of "Mon, 14 Mar 2011 18:56:25 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00784.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> For DW_AT_high_pc DWARF-4 has the comment Jan> The high PC value may be beyond the last valid instruction in the Jan> executable. Jan> which may suggest DW_AT_low_pc == DW_AT_high_pc == 0 may be valid Jan> and it should mean the whole address space. I find such case Jan> outside of the scope of this patch, such case already did not work Jan> as the partial symtabs reading already ignored DIEs with Jan> DW_AT_low_pc == DW_AT_high_pc. I would not worry about this case at all. The patch looks good to me. Jan> + complaint (&symfile_complaints, Jan> + _("DW_AT_low_pc %s is not < DW_AT_high_pc %s " Jan> + "for DIE at 0x%x [in module %s]"), Jan> + paddress (gdbarch, part_die->lowpc), Jan> + paddress (gdbarch, part_die->highpc), Jan> + part_die->offset, cu->objfile->name); Thanks for putting this info into the complaint. One of my minor wish-list items is that we would do this for all DWARF complaints. Tom