Re: [PATCH] gdb.base/setshow.exp: fix racy tests (PR testsuite/12649)

Marek Polacek
2011-04-19T07:01:37Z

On 04/18/2011 10:45 PM, Tom Tromey wrote:
> Marek> - gdb_test_multiple "set prompt (gdb) " "set prompt gdb" {
> Marek> + gdb_test_multiple "set prompt \\(gdb\\) " "set prompt gdb" {
>
> I think this should not be needed.

It is needed. Not that I'd see WHY it is so. But this is what I get without
those "\\":

FAIL: gdb.base/setshow.exp: set radix 11
FAIL: gdb.base/setshow.exp: set radix 16
FAIL: gdb.base/setshow.exp: show radix (16)
FAIL: gdb.base/setshow.exp: set radix 10
FAIL: gdb.base/setshow.exp: show radix (10)
FAIL: gdb.base/setshow.exp: set width 90
FAIL: gdb.base/setshow.exp: show width (90)
FAIL: gdb.base/setshow.exp: set write on
FAIL: gdb.base/setshow.exp: show write (on)
FAIL: gdb.base/setshow.exp: set symbol-reloading on
FAIL: gdb.base/setshow.exp: show symbol-reloading (on)
FAIL: gdb.base/setshow.exp: show user
FAIL: gdb.base/setshow.exp: set verbose on
FAIL: gdb.base/setshow.exp: show verbose (on)
FAIL: gdb.base/setshow.exp: set verbose off
FAIL: gdb.base/setshow.exp: show verbose (off)

=== gdb Summary ===

# of expected passes 60
# of unexpected failures 16

_With_ them all seems just fine:

=== gdb Summary ===

# of expected passes 76

Marek