From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27414 invoked by alias); 19 May 2011 19:27:09 -0000 Received: (qmail 27405 invoked by uid 22791); 19 May 2011 19:27:08 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 19 May 2011 19:26:48 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p4JJQdXk004577 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 19 May 2011 15:26:39 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p4JJQc5I027876; Thu, 19 May 2011 15:26:39 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p4JJQcXJ012547; Thu, 19 May 2011 15:26:38 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id BCD3937918A; Thu, 19 May 2011 13:26:37 -0600 (MDT) From: Tom Tromey To: Jiang Jilin Cc: Yao Qi , gdb-patches@sourceware.org, Hui Zhu Subject: Re: [PATCH] Rewrite the codes for opcode 0x0f01 and add more instructions support References: <1255182393-15292-1-git-send-email-freephp@gmail.com> <4AD28E95.1050404@vmware.com> <7d77a27d0910111921v13a8e8acpb98c29a9aa72ed8@mail.gmail.com> <4C929A9C.1050601@vmware.com> <4D91BE41.2010107@codesourcery.com> Date: Thu, 19 May 2011 19:27:00 -0000 In-Reply-To: (Jiang Jilin's message of "Tue, 29 Mar 2011 22:14:20 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00459.txt.bz2 >>>>> "Jiang" == Jiang Jilin writes: I'm sorry you haven't gotten a reply to this. Jiang> 2011-03-29 Jiang Jilin Jiang> * i386-tdep.c (i386_process_record): Rewrite the codes for Jiang> opcode 0x0f01 and add more instructions support. I am not the right person to review this. I would have to look up all this stuff in the x86 references to try to understand it. I'd appreciate it if Hui would reply about these details. Most of the code seems to at least be in the same style as the surrounding code, so at least on those grounds I find it basically ok. Jiang> + switch (reg_rm) Jiang> + { Jiang> + /* vmcall */ Jiang> + case 0x01: It looks like there is an extra space in the indentation here. Jiang> + q = yquery (_("\ Jiang> + Process record ignores the memory change of \ Jiang> + instruction at address %s\n\ Jiang> + because it can't get the value of the segment \ Jiang> + register.\n Do you want to stop the program?"), Reformatting this message like this is not ok. The way it was before the patch is more correct. Tom