From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11898 invoked by alias); 18 Jul 2011 15:33:36 -0000 Received: (qmail 11890 invoked by uid 22791); 18 Jul 2011 15:33:36 -0000 X-SWARE-Spam-Status: No, hits=-7.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 18 Jul 2011 15:33:20 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6IFXJXH003340 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 18 Jul 2011 11:33:19 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p6IFXJLr009099; Mon, 18 Jul 2011 11:33:19 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p6IFXIXF014033; Mon, 18 Jul 2011 11:33:18 -0400 From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] Fix implicit pointer vs. typedefs References: <20110718150124.GA24706@host1.jankratochvil.net> Date: Mon, 18 Jul 2011 16:52:00 -0000 In-Reply-To: <20110718150124.GA24706@host1.jankratochvil.net> (Jan Kratochvil's message of "Mon, 18 Jul 2011 17:01:24 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00424.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> found missing check_typedef in indirect_pieced_value, with the extended Jan> testcase the fix will: [...] Jan> No regressions on {x86_64,x86_64-m32,i686}-fedora16pre-linux-gnu. Jan> I will check it in if no responses appear. Thanks Jan. It looks good to me. I have come around to your view that we should get rid of check_typedef. Tom