From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12647 invoked by alias); 6 Feb 2012 20:27:01 -0000 Received: (qmail 12617 invoked by uid 22791); 6 Feb 2012 20:27:01 -0000 X-SWARE-Spam-Status: No, hits=-7.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 06 Feb 2012 20:26:47 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q16KQhGn031435 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 6 Feb 2012 15:26:44 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q16KQhAx024843; Mon, 6 Feb 2012 15:26:43 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id q16KQfuG017859; Mon, 6 Feb 2012 15:26:41 -0500 From: Tom Tromey To: "Gustavo\, Luis" Cc: gdb-patches@sourceware.org Subject: Re: [rfc target-side break conditions 3/5 v2] GDB-side changes References: <4F230A13.9060400@mentor.com> Date: Mon, 06 Feb 2012 20:27:00 -0000 In-Reply-To: <4F230A13.9060400@mentor.com> (Luis Gustavo's message of "Fri, 27 Jan 2012 18:33:23 -0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00066.txt.bz2 >>>>> "Luis" == Luis Gustavo writes: Luis> A few more changes on this patch. It addresses all the previous Luis> comments and suggestions. I have a few minor notes, nothing serious. I think someone other than me should do the final review of this patch. A couple other things I wanted to mention -- First, I think this is a great patch series and I like it quite a bit. I want to see it go in. Second, I was wondering if you have any plans to extend agent expressions to provide more coverage for DWARF expressions. It would be somewhat interesting, I think, to get some idea of how often GCC generates untranslatable expressions for real code. (Like, looking at all the DWARF expressions in the distro... or at least some big libraries.) Luis> +static const char *condition_evaluation_enums[] = { After Jan's patch I think you will need another const in there. Luis> +/* Translate a condition evaluation mode MODE into either "gdb" Luis> + or "target. This is used mostly to translate from "auto" to the Missing quote after "target". Luis> + /* Signals that the condition has changed since the last time Luis> + we updated the global location list. This means the condition Luis> + needs to be sent to the target again. This is used together Luis> + with target-side breakpoint conditions. Luis> + Luis> + This field has 3 special values: Luis> + Luis> + 0: It means there has been no condition changes. Luis> + Luis> + 1: It means this location had its condition modified. Luis> + Luis> + 2: It means we already marked all the locations that are duplicates Luis> + of this location and thus we don't need to call Luis> + force_breakpoint_reinsertion (...) for this location. */ Luis> + Luis> + char condition_changed; How about an enum instead of numerical constants? Tom