From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25411 invoked by alias); 20 Dec 2006 23:57:54 -0000 Received: (qmail 25393 invoked by uid 22791); 20 Dec 2006 23:57:53 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 20 Dec 2006 23:57:48 +0000 Received: from zps76.corp.google.com (zps76.corp.google.com [172.25.146.76]) by smtp-out.google.com with ESMTP id kBKNvKi8015929; Wed, 20 Dec 2006 23:57:21 GMT Received: from localhost.localdomain.google.com (dhcp-172-18-118-195.corp.google.com [172.18.118.195]) (authenticated bits=0) by zps76.corp.google.com with ESMTP id kBKNtWmh021102 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 20 Dec 2006 15:55:33 -0800 To: gkeating@apple.com (Geoffrey Keating) Cc: dj@redhat.com, ian@airs.com, gcc-patches@gcc.gnu.org, binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: fix end-of-string overrun problems in C++ demangler References: <20061220223511.F04CE5771424@geoffk5.apple.com> From: Ian Lance Taylor Date: Wed, 20 Dec 2006 23:57:00 -0000 In-Reply-To: <20061220223511.F04CE5771424@geoffk5.apple.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.4 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00273.txt.bz2 gkeating@apple.com (Geoffrey Keating) writes: > 2006-12-20 Geoffrey Keating > > * cp-demangle.h: Add comment explaining what to do to avoid > overrunning string. > (d_check_char): New. > (d_next_char): Don't advance past trailing '\0'. > * cp-demangle.c (cplus_demangle_mangled_name): Use d_check_char. > (d_nested_name): Likewise. > (d_special_name): Likewise. > (d_call_offset): Likewise. > (d_function_type): Likewise. > (d_array_type): Likewise. > (d_pointer_to_member_type): Likewise. > (d_template_param): Likewise. > (d_template_args): Likewise. > (d_template_arg): Likewise. > (d_expr_primary): Likewise. > (d_local_name): Likewise. > (d_substitution): Likewise. > (d_ctor_dtor_name): Use d_advance rather than d_next_char. > * testsuite/test-demangle.c: Include sys/mman.h. > (MAP_ANONYMOUS): Define. > (protect_end): New. > (main): Use protect_end. > * testsuite/demangle-expected: Add testcases for overrunning > the end of the string. Looks good to me. Thanks for cleaning this up. Ian