From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12123 invoked by alias); 27 Sep 2008 20:24:52 -0000 Received: (qmail 12114 invoked by uid 22791); 27 Sep 2008 20:24:51 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 27 Sep 2008 20:24:16 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id m8RKKEsw017636; Sat, 27 Sep 2008 16:20:14 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m8RKKDwa014190; Sat, 27 Sep 2008 16:20:13 -0400 Received: from opsy.redhat.com (vpn-10-15.bos.redhat.com [10.16.10.15]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id m8RKKBtk011194; Sat, 27 Sep 2008 16:20:12 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id B05B03784B4; Sat, 27 Sep 2008 14:19:08 -0600 (MDT) To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: RFA: change K&R to ISO References: <200809270049.06897.pedro@codesourcery.com> From: Tom Tromey Reply-To: Tom Tromey X-Attribution: Tom Date: Sat, 27 Sep 2008 20:24:00 -0000 In-Reply-To: <200809270049.06897.pedro@codesourcery.com> (Pedro Alves's message of "Sat\, 27 Sep 2008 00\:49\:06 +0100") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00542.txt.bz2 Tom> I noticed some K&R-style function definitions. Pedro> OK. Obvious even nowadays? I considered that, but I tend to be conservative when applying the obvious rule. Usually I think I only use it for clearly incorrect comments, typos, and build breakages. That said, I'm happy to follow whatever the gdb guidelines actually are. Tom