From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: Re: Make target_ops->to_has_FOO functions instead of variables.
Date: Fri, 05 Jun 2009 18:41:00 -0000 [thread overview]
Message-ID: <m3tz2uttfj.fsf@fleche.redhat.com> (raw)
In-Reply-To: <200906041620.38550.pedro@codesourcery.com>
>>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:
Pedro> The patch below addresses this, by rewriting the target_has_FOO
Pedro> properties as methods, so that they can return a different
Pedro> result depending on the current inferior/program.
Everything in there that I understand seems reasonable to me.
Pedro> +extern int target_has_all_memory_1 (void);
Pedro> +#define target_has_all_memory target_has_all_memory_1 ()
What do you think of a mechanical follow-up patch that changes
"target_has_*" to "target_has_* ()"?
I generally prefer to avoid object-like macros that expand to function
calls, as I think they obscure the meaning of the code.
Tom
next prev parent reply other threads:[~2009-06-05 18:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 15:20 Pedro Alves
2009-06-05 18:41 ` Tom Tromey [this message]
2009-06-05 19:44 ` Pedro Alves
2009-06-07 17:05 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3tz2uttfj.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox