Re: [patch 6/8] Types GC [the GC itself]

[Tom Tromey <tromey@redhat.com>]

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> run the mark-and-sweep garbage collector.  Just without the next
Jan> patch 7/8 there will be crashes as not all the GDB reclaimable
Jan> types will be properly being marked.

This seems reasonable to me.  I have a couple nits though.

Jan> +/* A traverse callback for type_group_link_table which removes any
Jan> +   type_group_link whose reference count is now zero (unused link).  */

Why bother with reference counts?

Jan> +void
Jan> +exp_types_mark_used (struct expression *exp)
Jan> +{
Jan> +  exp_iterate (exp, exp_types_mark_used_iter, NULL, NULL);
Jan> +}

This is not called anywhere with this patch.  I didn't check later
patches yet, so just ignore this if it is called later.

Tom