From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31949 invoked by alias); 14 Aug 2009 22:34:49 -0000 Received: (qmail 31901 invoked by uid 22791); 14 Aug 2009 22:34:49 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_44,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 14 Aug 2009 22:34:35 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n7EMYWx0012490 for ; Fri, 14 Aug 2009 18:34:32 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n7EMYWaQ023012 for ; Fri, 14 Aug 2009 18:34:32 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n7EMYVlx022089; Fri, 14 Aug 2009 18:34:32 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 6E9303784C5; Fri, 14 Aug 2009 16:34:31 -0600 (MDT) To: Jan Kratochvil Cc: gdb-patches@sources.redhat.com Subject: Re: [patch] Replace reread_symbols by load+free calls References: <8ac60eac0906101839t4d3978fyc1c6d3b3e2eccb6e@mail.gmail.com> <8ac60eac0906101842y2d2fc9fco331cb4336d9508d0@mail.gmail.com> <8ac60eac0906161342m67c30151lc7f685e0eb36e41f@mail.gmail.com> <8ac60eac0906161407s6498913cu5e50e930d599be77@mail.gmail.com> <20090623150322.GA7654@host0.dyn.jankratochvil.net> <20090623182139.GA30969@host0.dyn.jankratochvil.net> <20090625192120.GA29930@host0.dyn.jankratochvil.net> From: Tom Tromey Reply-To: tromey@redhat.com Date: Fri, 14 Aug 2009 23:09:00 -0000 In-Reply-To: <20090625192120.GA29930@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Thu\, 25 Jun 2009 21\:21\:20 +0200") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00208.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Sorry about the long delay on this. I try not to just drop threads I'm involved in, but sometimes I get distracted. Jan> IMO the whole `struct objfile' should replaced by a new one Jan> (instead of its in-place patching). Which will probably have Jan> other dependencies... Tom> I'm interested to hear your idea and reasoning. Jan> Sometimes there are differentiations between complete objects Jan> destructors (objfile_free_data) and in-place object deletions Jan> (clear_objfile_data); OK did not briefly found more such cases now. Jan> Expecting it was there for some performance improvements which not Jan> worth it nowadays. I misunderstood something you were saying earlier in the thread -- I thought you were talking about dropping 'struct objfile' itself in favor of some new datastructure (as opposed to slowly refactoring it). But, now I understand that you really meant that reread_symbols should be rewritten. I realize you pulled this patch from consideration. But, FWIW, I tend to think it is a good idea, because it ensures that all the hooks and observers will be run identically in both cases. Tom