From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28050 invoked by alias); 11 Jan 2010 17:58:30 -0000 Received: (qmail 28028 invoked by uid 22791); 11 Jan 2010 17:58:28 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 Jan 2010 17:58:24 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0BHwNOe002803 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 11 Jan 2010 12:58:23 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o0BHwMrn026143; Mon, 11 Jan 2010 12:58:22 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o0BHwL6W016587; Mon, 11 Jan 2010 12:58:21 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 28BBB378190; Mon, 11 Jan 2010 10:58:21 -0700 (MST) From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] objfile_relocate: Call breakpoint_re_set on-demand References: <20100110233410.GC1435@host0.dyn.jankratochvil.net> Reply-To: tromey@redhat.com Date: Mon, 11 Jan 2010 17:58:00 -0000 In-Reply-To: <20100110233410.GC1435@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Mon, 11 Jan 2010 00:34:10 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00261.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> this is just a performance optimization to avoid some needless calls. It seems reasonable enough to me. Jan> 2010-01-11 Jan Kratochvil Jan> * objfiles.c (objfile_relocate1): Change the return type to int. Jan> Describe the new return value. Return non-zero if data changed. Jan> (objfile_relocate): New variable changed. Set it. Call Jan> breakpoint_re_set depending on CHANGED. Ok. Tom