From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8482 invoked by alias); 7 Jun 2010 18:13:07 -0000 Received: (qmail 8472 invoked by uid 22791); 7 Jun 2010 18:13:06 -0000 X-SWARE-Spam-Status: No, hits=-5.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Jun 2010 18:13:01 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o57ICxqX027923 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 7 Jun 2010 14:12:59 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o57ICxM3032620; Mon, 7 Jun 2010 14:12:59 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o57ICwUq017301; Mon, 7 Jun 2010 14:12:58 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 3CFCA50802E; Mon, 7 Jun 2010 12:12:58 -0600 (MDT) From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch 2/2] DW_OP_call: Support DW_OP_call2 and DW_OP_call4 References: <20100607115645.GC24148@host0.dyn.jankratochvil.net> Reply-To: Tom Tromey Date: Mon, 07 Jun 2010 18:13:00 -0000 In-Reply-To: <20100607115645.GC24148@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Mon, 7 Jun 2010 13:56:45 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00180.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> Fix PR 10640. Would you mind filing a new PR for DW_OP_call_ref? This is one of the few remaining unimplemented operators... Jan> +struct dwarf2_locexpr_baton Jan> +fetch_die_location_block (unsigned int offset, struct dwarf2_per_cu_data *per_cu) I think this function name should have a dwarf2_ prefix. Also it looks like this line wraps. Jan> --- a/gdb/symfile.h Jan> +++ b/gdb/symfile.h Jan> @@ -569,6 +569,10 @@ extern int dwarf2_has_info (struct objfile *); Jan> extern void dwarf2_build_psymtabs (struct objfile *); Jan> extern void dwarf2_build_frame_info (struct objfile *); Jan> +struct dwarf2_per_cu_data; Jan> +extern struct dwarf2_locexpr_baton fetch_die_location_block Jan> + (unsigned int offset, struct dwarf2_per_cu_data *per_cu); I think this should go in one of the dwarf headers, not symfile.h. I think probably dwarf2loc.h, near the other functions taking a dwarf2_per_cu_data. Ok with these changes. Thanks. Tom