From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-74331-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 32180 invoked by alias); 13 Jul 2010 17:16:13 -0000
Received: (qmail 32170 invoked by uid 22791); 13 Jul 2010 17:16:12 -0000
X-SWARE-Spam-Status: No, hits=-6.0 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 13 Jul 2010 17:16:06 +0000
Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o6DHG3Fc024312	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Tue, 13 Jul 2010 13:16:04 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o6DHG2D0003871;	Tue, 13 Jul 2010 13:16:02 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o6DHG13c026483;	Tue, 13 Jul 2010 13:16:01 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)	id 27FDE3782A3; Tue, 13 Jul 2010 11:16:01 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: sami wagiaalla <swagiaal@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 1/3] Change cplus_specific to an alocated struct
References: <4BFD4230.3030600@redhat.com> <m34ohdlap4.fsf@fleche.redhat.com>	<4C167FCA.7030300@redhat.com> <m3pqzrucpg.fsf@fleche.redhat.com>	<4C3B5907.2080200@redhat.com>
Date: Tue, 13 Jul 2010 17:16:00 -0000
In-Reply-To: <4C3B5907.2080200@redhat.com> (sami wagiaalla's message of "Mon,	12 Jul 2010 14:03:51 -0400")
Message-ID: <m3tyo3ti9a.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-07/txt/msg00222.txt.bz2

>>>>> "Sami" == sami wagiaalla <swagiaal@redhat.com> writes:

Sami> This patch cplus_specific is renamed to mangled_lang

Sami> -    struct cplus_specific
Sami> +    struct mangled_lang

I'm not super fond of this name, but I don't have a better suggestion.

Please add a new comment above the "struct" line that describes the
purpose of the struct.

Sami>      {
Sami>        /* This is in fact used for C++, Java, and Objective C.  */
Sami>        char *demangled_name;

Please rewrite this comment to describe the meaning of this field.

This is ok with those changes. 

Tom