From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7323 invoked by alias); 27 Sep 2010 17:28:30 -0000 Received: (qmail 7309 invoked by uid 22791); 27 Sep 2010 17:28:29 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 27 Sep 2010 17:28:23 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o8RHSHE4006861 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 27 Sep 2010 13:28:17 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o8RHSGuO013733; Mon, 27 Sep 2010 13:28:17 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o8RHSFC5021388; Mon, 27 Sep 2010 13:28:16 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 4446B378183; Mon, 27 Sep 2010 11:28:14 -0600 (MDT) From: Tom Tromey To: "Pierre Muller" Cc: Subject: Re: Your INTERMEDIATE_ENCODING patch for Solaris References: <20100731162500.32FAE5664F4@henry1.codesourcery.com> <15264.6257346079$1282142643@news.gmane.org> <004b01cb3faf$b07ed580$117c8080$@muller@ics-cnrs.unistra.fr> <001b01cb48ee$6b8425f0$428c71d0$@muller@ics-cnrs.unistra.fr> <44796.6229789474$1283326243@news.gmane.org> <000301cb4aa0$7c44fd70$74cef850$@muller@ics-cnrs.unistra.fr> <001f01cb5574$78252a60$686f7f20$@muller@ics-cnrs.unistra.fr> <20078.2261243605$1284672670@news.gmane.org> <001101cb5663$f6011c10$e2035430$@muller@ics-cnrs.unistra.fr> <000901cb5aef$afb465b0$0f1d3110$@muller@ics-cnrs.unistra.fr> Date: Mon, 27 Sep 2010 18:42:00 -0000 In-Reply-To: <000901cb5aef$afb465b0$0f1d3110$@muller@ics-cnrs.unistra.fr> (Pierre Muller's message of "Thu, 23 Sep 2010 09:19:39 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00452.txt.bz2 Tom> Yeah, how about we make x0108 the minimal acceptable version? Tom> It was released in 2002, that seems plenty old to me. Tom> If you agree, I will make the change. Pierre> I agree, furthermore HAVE_LIBICONVLIST Pierre> should always be set in config.h in that case, Pierre> which avoids the direct call to 'iconv -l'. Here is the patch I am checking in. Thank you for all the testing you did for this. Tom 2010-09-27 Tom Tromey * gdb_wchar.h: Change minimum libiconv to 0x108. Index: gdb_wchar.h =================================================================== RCS file: /cvs/src/src/gdb/gdb_wchar.h,v retrieving revision 1.4 diff -u -r1.4 gdb_wchar.h --- gdb_wchar.h 15 Sep 2010 20:18:47 -0000 1.4 +++ gdb_wchar.h 27 Sep 2010 17:21:10 -0000 @@ -52,12 +52,11 @@ /* We use "btowc" as a sentinel to detect functioning wchar_t support. We check for either __STDC_ISO_10646__ or a new-enough libiconv in order to ensure we can convert to and from wchar_t. We choose - libiconv version 0x10D because it was reported that earlier - versions do not always accept "wchar_t" as an encoding - argument. */ + libiconv version 0x108 because it is the first version with + iconvlist. */ #if defined (HAVE_ICONV) && defined (HAVE_WCHAR_H) && defined (HAVE_BTOWC) \ && (defined (__STDC_ISO_10646__) \ - || (defined (_LIBICONV_VERSION) && _LIBICONV_VERSION >= 0x10D)) + || (defined (_LIBICONV_VERSION) && _LIBICONV_VERSION >= 0x108)) #include #include @@ -84,7 +83,7 @@ #else #define INTERMEDIATE_ENCODING "UCS-4LE" #endif -#elif defined (_LIBICONV_VERSION) && _LIBICONV_VERSION >= 0x10D +#elif defined (_LIBICONV_VERSION) && _LIBICONV_VERSION >= 0x108 #define INTERMEDIATE_ENCODING "wchar_t" #else /* This shouldn't happen, because the earlier #if should have filtered