From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9508 invoked by alias); 12 Oct 2010 22:51:51 -0000 Received: (qmail 9500 invoked by uid 22791); 12 Oct 2010 22:51:50 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Oct 2010 22:51:41 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o9CMpbrR012410 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 12 Oct 2010 18:51:37 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id o9CMpbWa014999; Tue, 12 Oct 2010 18:51:37 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o9CMpSSQ004546; Tue, 12 Oct 2010 18:51:34 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id D36CF3780FB; Tue, 12 Oct 2010 16:51:27 -0600 (MDT) From: Tom Tromey To: Marc Khouzam Cc: "'gdb-patches\@sourceware.org'" Subject: Re: [MI][patch] broken -target-detach References: Date: Tue, 12 Oct 2010 22:51:00 -0000 In-Reply-To: (Marc Khouzam's message of "Wed, 29 Sep 2010 21:35:29 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00210.txt.bz2 >>>>> "Marc" == Marc Khouzam writes: I'm sorry about the delay. I recommend pinging your patches weekly. Marc> Using the --thread-group flag (alike -thread and --frame) tells the MI Marc> command to focus on the thread-group specified and then execute the Marc> command. It seems reasonable to me. Marc> + /* We are not dealing with a pid. Check for group id */ Marc> + if (*(argv[0]) != 'i') Marc> + error (_("Invalid pid or thread-group id '%s'"), argv[0]); Marc> + Marc> + id = strtoul (argv[0] + 1, &end, 0); Marc> + if (*end != '\0') Marc> + error (_("Invalid syntax of group id '%s'"), argv[0]); This code is duplicated in various spots in MI. Seems ugly -- but not your problem. I think this patch looks good. It needs a ChangeLog entry. A test case would be nice to have. I think it would be better for Volodya to review it, since he is the MI maintainer. If he doesn't review it within a week or so, please ping it and I will approve it. thanks, Tom