From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29054 invoked by alias); 14 Feb 2011 19:33:55 -0000 Received: (qmail 29045 invoked by uid 22791); 14 Feb 2011 19:33:54 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Feb 2011 19:33:48 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p1EJXes3026603 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 14 Feb 2011 14:33:40 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p1EJXebm020511; Mon, 14 Feb 2011 14:33:40 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p1EJXdQx031282; Mon, 14 Feb 2011 14:33:40 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 675763781C7; Mon, 14 Feb 2011 12:33:39 -0700 (MST) From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org, Yao Qi Subject: Re: Change gdb/common/ to use Automake References: <4D30E23F.3080103@codesourcery.com> <201102141822.12309.pedro@codesourcery.com> Date: Mon, 14 Feb 2011 19:39:00 -0000 In-Reply-To: <201102141822.12309.pedro@codesourcery.com> (Pedro Alves's message of "Mon, 14 Feb 2011 18:22:12 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00291.txt.bz2 Tom> It is vaguely bogus due to the dummy-config.h and PACKAGE_NAME stuff. Tom> Autoconf doesn't seem to let you turn this off, and we end up with Tom> conflicts. We can probably fix this more cleanly than I have below; I Tom> just want to get feedback on the idea before committing to that. Pedro> Is there any downside to this? My automake-foo is quite weak, Pedro> almost non-existant, so excuse me if this sounds dumb. To my hack? Yeah -- if we add AC_DEFINEs to common/configure.ac, they won't propagate to the code. We can fix this by #including the common/config.h first, then #undef'ing the stuff that autoconf forces us to have. Tom> +AM_INIT_AUTOMAKE([cygnus no-define no-dist -Wall]) Pedro> Wasn't the cygnus mode deprecated? E.g., I see bfd/ stopped Pedro> using it in 2009. Hah, shows what I know. Maybe `foreign' is more appropriate now, I can check into it if this idea seems ok. Tom