From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7521 invoked by alias); 24 Feb 2011 19:26:44 -0000 Received: (qmail 7511 invoked by uid 22791); 24 Feb 2011 19:26:43 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 24 Feb 2011 19:26:39 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p1OJQHxm014192 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 24 Feb 2011 14:26:17 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p1OJQGrW001127; Thu, 24 Feb 2011 14:26:16 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p1OJQG9F023146; Thu, 24 Feb 2011 14:26:16 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id E1F29378388; Thu, 24 Feb 2011 12:26:15 -0700 (MST) From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 07/18] remote-wtxapi: The WTX API abstraction layer. References: <1298569763-18784-1-git-send-email-brobecker@adacore.com> <1298569763-18784-8-git-send-email-brobecker@adacore.com> Date: Thu, 24 Feb 2011 19:44:00 -0000 In-Reply-To: <1298569763-18784-8-git-send-email-brobecker@adacore.com> (Joel Brobecker's message of "Thu, 24 Feb 2011 12:49:12 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00729.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: I did not really try to read this patch, but I randomly noticed: Joel> +static void Joel> +wtxapi_parse_obj_unloaded_event (char *event_str, Joel> + struct wtxapi_obj_unloaded_event *event) [...] Joel> + wtx_opt_events_debug (1, "OBJ_LOADED: module_filename = \"%s\"", Joel> + event->module_filename); I think that should probably say `OBJ_UNLOADED'. Tom