From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21727 invoked by alias); 4 Apr 2011 15:42:18 -0000 Received: (qmail 21715 invoked by uid 22791); 4 Apr 2011 15:42:17 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 04 Apr 2011 15:41:43 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p34FfYYJ030404 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 4 Apr 2011 11:41:34 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p34FfYfh004407; Mon, 4 Apr 2011 11:41:34 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p34FfXel028628; Mon, 4 Apr 2011 11:41:33 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id A163B37848E; Mon, 4 Apr 2011 09:41:32 -0600 (MDT) From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: FYI: small simplification in breakpoint.c References: <201104041633.37786.pedro@codesourcery.com> <201104041639.16444.pedro@codesourcery.com> Date: Mon, 04 Apr 2011 15:42:00 -0000 In-Reply-To: <201104041639.16444.pedro@codesourcery.com> (Pedro Alves's message of "Mon, 4 Apr 2011 16:39:16 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00059.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> On Monday 04 April 2011 16:33:37, Pedro Alves wrote: >> catch_exceptions also prints the exception string, if >> any (w/ print_any_exception), was the change intentional? (your note seems to >> imply this is meant as a 1-1 replacement, but I do see a few >> exception_print's below the TRY_CATCH, so I can't tell.) Pedro> Oh, sorry. Please ignore me. That's catch_exceptionS, but you Pedro> replaced a use of catch_exception, which doesn't do that. FWIW, I'm not a fan of having two functions with such similar names. This has bitten me a couple of times. Tom