From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5274 invoked by alias); 11 Jul 2011 14:37:11 -0000 Received: (qmail 5116 invoked by uid 22791); 11 Jul 2011 14:37:09 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 Jul 2011 14:36:53 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6BEaqdw003010 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 11 Jul 2011 10:36:52 -0400 Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p6BEapUH011890; Mon, 11 Jul 2011 10:36:52 -0400 From: Phil Muldoon To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [patch] PR python/12438 References: Reply-to: pmuldoon@redhat.com X-URL: http://www.redhat.com Date: Mon, 11 Jul 2011 17:16:00 -0000 In-Reply-To: (Tom Tromey's message of "Thu, 07 Jul 2011 12:48:04 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00273.txt.bz2 Tom Tromey writes: >>>>>> "Phil" == Phil Muldoon writes: > > Phil> I was adding the new commands to the old list. So you were quite > Phil> right. Sorry about that ;) > > No problem. > > I think this change should have a NEWS entry -- both to document that > the default changed and to mention the new commands. > > Phil> +struct cmd_list_element *maint_set_python_list; > Phil> +struct cmd_list_element *maint_show_python_list; > Phil> + > Phil> +/* Lists for 'set python' commands. */ > Phil> + > Phil> +struct cmd_list_element *user_set_python_list; > Phil> +struct cmd_list_element *user_show_python_list; > > These can all be static. > > Code bits ok with that change. So committed with doc and code changes. Cheers Phil