From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-82811-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9387 invoked by alias); 4 Aug 2011 14:21:59 -0000
Received: (qmail 9377 invoked by uid 22791); 4 Aug 2011 14:21:58 -0000
X-SWARE-Spam-Status: No, hits=-7.3 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 04 Aug 2011 14:21:42 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p74ELYfm030516	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 4 Aug 2011 10:21:34 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p74ELYds002892;	Thu, 4 Aug 2011 10:21:34 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p74ELWTH007063;	Thu, 4 Aug 2011 10:21:32 -0400
From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org, Abhijit Halder <abhijit.k.halder@gmail.com>,        Sergio Durigan Junior <sergiodj@redhat.com>,        Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Re: [PATCH] An implementation of pipe to make I/O communication between gdb and shell.
References: <CAOhZP9zU2K01zFDkChtutGT6yJjUeWYeGRNAAgPgM5rKwrgysg@mail.gmail.com>	<m3vcuecrrf.fsf@redhat.com>	<CAOhZP9yENHtgW4RSMMdnyvfPJ=yovDo_c5fG3KMC4-oa6NJBrw@mail.gmail.com>	<201108041029.37721.pedro@codesourcery.com>
Date: Thu, 04 Aug 2011 14:21:00 -0000
In-Reply-To: <201108041029.37721.pedro@codesourcery.com> (Pedro Alves's	message of "Thu, 4 Aug 2011 10:29:37 +0100")
Message-ID: <m3ty9xz28j.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-08/txt/msg00071.txt.bz2

>>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:

I haven't really read this thread yet, but I wanted to chime in...

>> +      pipe->handle = popen (pipe->shell_cmd, pipe->mode);

Pedro> I'm not sure that'll build on all supported hosts.  
Pedro> I think on Windows that may require use of _popen instead.

libiberty has the already-portable 'pexecute' code for this kind of
thing.

Tom