From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20198 invoked by alias); 30 Aug 2011 17:34:24 -0000 Received: (qmail 19654 invoked by uid 22791); 30 Aug 2011 17:34:23 -0000 X-SWARE-Spam-Status: No, hits=-7.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_BJ X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 30 Aug 2011 17:34:08 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7UHY7hm000542 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 30 Aug 2011 13:34:07 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p7UHY7ri010853; Tue, 30 Aug 2011 13:34:07 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p7UHY66I020116; Tue, 30 Aug 2011 13:34:06 -0400 From: Tom Tromey To: matt rice Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 5/7] [python] API for macros: gdb.Objfile symtabs method. References: <1314198654-9008-1-git-send-email-ratmice@gmail.com> <1314198654-9008-6-git-send-email-ratmice@gmail.com> Date: Tue, 30 Aug 2011 17:34:00 -0000 In-Reply-To: <1314198654-9008-6-git-send-email-ratmice@gmail.com> (matt rice's message of "Wed, 24 Aug 2011 08:10:52 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00618.txt.bz2 >>>>> "matt" == matt rice writes: matt> 2011-08-23 Matt Rice matt> * python/py-symtab.h: New file. Make symtab_to_symtab_object public. matt> * python/py-objfile.c (objfpy_symtabs): New method. matt> (objfile_object_methods): Ditto. A couple notes on this. matt> +static PyObject * matt> +objfpy_symtabs (PyObject *self, PyObject *ignore) matt> +{ matt> + objfile_object *obj = (objfile_object *) self; matt> + struct symtab *symtabs; matt> + PyObject *list; matt> + PyObject *py_symtab; matt> + matt> + if (! obj->objfile) matt> + return Py_None; You need Py_RETURN_NONE. I think most of our objects will throw an exception if you try to operate on them when they are in the 'invalid' state; if that is true then I think this should conform. matt> + while(symtabs) Missing space. matt> + { "symtabs", objfpy_symtabs, METH_NOARGS, matt> + "symtabs () -> List.\n\ matt> +A List containing the object file's valid symtabs." }, I don't mind this method per se, but I think people will find it confusing, as it only returns full symtabs -- but there is no direct way for the Python programmer to cause symtab expansion. matt> +PyObject * matt> +symtab_to_symtab_object (struct symtab *symtab); In addition to what Phil said, the norm is not to split declarations after the type -- only definitions. Tom