Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: "gp \>\> \"gdb-patches\@sourceware.org ml\""
	<gdb-patches@sourceware.org>
Subject: Re: [RFA] Updated path expression computations for varobj trees
Date: Tue, 20 Dec 2011 15:25:00 -0000	[thread overview]
Message-ID: <m3ty4vl11b.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4EEBCC7D.4020103@redhat.com> (Keith Seitz's message of "Fri, 16	Dec 2011 14:55:57 -0800")

>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> 	* lib/mi-support.exp: Expand comments about PATH_EXPR.
Keith> 	(varobj_tree::get_path_expr): Assume that all varobjs are
Keith> 	compound unless they are known simple types.
Keith> 	Adjust path expressions based on parent type, path parent type,
Keith> 	and tree language.
Keith> 	(varobj_tree::walk_tree): Add LANGUAGE parameter and save it into
Keith> 	the root varobj.
Keith> 	(mi_walk_varobj_tree): Add LANGUAGE parameter.

This is ok.

I'm not super fond of the type regexp thing, but I suppose we can always
enhance it more later if need be.

Tom


  reply	other threads:[~2011-12-20 15:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-16 23:43 Keith Seitz
2011-12-20 15:25 ` Tom Tromey [this message]
2011-12-20 17:48   ` Keith Seitz
2012-01-05 20:05     ` Keith Seitz
2012-01-12 21:30       ` Tom Tromey
2012-01-12 22:33         ` Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3ty4vl11b.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=keiths@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox