From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11963 invoked by alias); 5 Dec 2013 23:06:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11953 invoked by uid 89); 5 Dec 2013 23:06:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Dec 2013 23:06:54 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rB5N6kAW023846 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 5 Dec 2013 18:06:47 -0500 Received: from psique (ovpn-113-192.phx2.redhat.com [10.3.113.192]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rB5N6iDQ001683 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 5 Dec 2013 18:06:45 -0500 From: Sergio Durigan Junior To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/4] remove some sym_probe_fns methods References: <1386100019-27379-1-git-send-email-tromey@redhat.com> <1386100019-27379-3-git-send-email-tromey@redhat.com> X-URL: http://www.redhat.com Date: Thu, 05 Dec 2013 23:06:00 -0000 In-Reply-To: <1386100019-27379-3-git-send-email-tromey@redhat.com> (Tom Tromey's message of "Tue, 3 Dec 2013 12:46:57 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00215.txt.bz2 On Tuesday, December 03 2013, Tom Tromey wrote: > While looking into the probe API, it seemed to me that there were a > number of methods in sym_probe_fns that were not needed. This patch > removes them. > > Specifically, it seems to me that sym_probe_fns ought to be concerned > with the API for constructing the probes. Any method relating to some > aspect of an individual probe can be handled via the probe's own > vtable. That is, the double indirection here doesn't seem useful -- > it certainly isn't in fact used, but also I couldn't think of a > potential use. This patch is great and needed, thanks a lot. The cleanup is more than welcome. I'll wait until you commit your patches so that I can rebase mine on top of them. Thanks, -- Sergio