Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andreas Arnez <arnez@linux.vnet.ibm.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: gdb-patches@sourceware.org, Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Re: [PATCH] Big-endian targets: don't ignore offset into DW_OP_implicit_value
Date: Wed, 01 Feb 2017 09:09:00 -0000	[thread overview]
Message-ID: <m3tw8enupj.fsf@oc1027705133.ibm.com> (raw)
In-Reply-To: <m3r33othxf.fsf@oc1027705133.ibm.com> (Andreas Arnez's message of	"Fri, 27 Jan 2017 20:35:24 +0100")

On Fri, Jan 27 2017, Andreas Arnez wrote:

> On Wed, Jan 25 2017, Yao Qi wrote:
>

[...]

>> All these values are from debug information rather than inferior memory,
>> does it make sense to run these tests above with both big and little
>> endianess?
>
> I've tried, but I don't know to make it work.  Switching to the opposite
> endianness affects more than just the byte order of variable contents;
> the variables are not even found any more.  Any idea?
>
>> Otherwise, patch is good to me.

Is it OK then to push the patch?  The logic for testing both little- and
big-endian byte order can still be added later, right?

--
Andreas


  reply	other threads:[~2017-02-01  9:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-12 19:24 Andreas Arnez
2017-01-19 17:44 ` Yao Qi
2017-01-19 18:21   ` Andreas Arnez
2017-01-24  9:42     ` [PATCH 0/2] Add DW_OP_implicit_value in dwarf assembler Yao Qi
2017-01-24  9:43       ` [PATCH 1/2] Handle DW_OP_GNU_implicit_pointer " Yao Qi
2017-01-24  9:43       ` [PATCH 2/2] Use dwarf assembler in gdb.dwarf2/implptr-64bit.exp Yao Qi
2017-01-24 19:21         ` Andreas Arnez
2017-01-25 16:26           ` Yao Qi
2017-01-25 22:12 ` [PATCH] Big-endian targets: don't ignore offset into DW_OP_implicit_value Yao Qi
2017-01-27 19:35   ` Andreas Arnez
2017-02-01  9:09     ` Andreas Arnez [this message]
2017-02-01  9:16       ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3tw8enupj.fsf@oc1027705133.ibm.com \
    --to=arnez@linux.vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox