From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25988 invoked by alias); 31 May 2017 14:24:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25916 invoked by uid 89); 31 May 2017 14:24:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=scary, monster X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 31 May 2017 14:24:23 +0000 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v4VEO7Wt001451 for ; Wed, 31 May 2017 10:24:08 -0400 Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109]) by mx0b-001b2d01.pphosted.com with ESMTP id 2aspg4gmcj-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 31 May 2017 10:24:08 -0400 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 31 May 2017 15:24:03 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp13.uk.ibm.com (192.168.101.143) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 31 May 2017 15:24:01 +0100 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v4VEO1f49896410; Wed, 31 May 2017 14:24:01 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id ECB504C058; Wed, 31 May 2017 15:22:26 +0100 (BST) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CE85D4C044; Wed, 31 May 2017 15:22:26 +0100 (BST) Received: from oc1027705133.ibm.com (unknown [9.152.212.151]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Wed, 31 May 2017 15:22:26 +0100 (BST) From: Andreas Arnez To: Simon Marchi Cc: gdb-patches@sourceware.org, qiyaoltc@gmail.com Subject: Re: [PATCH v2 00/19] Various DWARF piece fixes References: <1494352015-10465-1-git-send-email-arnez@linux.vnet.ibm.com> <8694ad33433a8f7018b98e8d9eb8e574@polymtl.ca> Date: Wed, 31 May 2017 14:24:00 -0000 In-Reply-To: <8694ad33433a8f7018b98e8d9eb8e574@polymtl.ca> (Simon Marchi's message of "Tue, 30 May 2017 22:44:31 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 x-cbid: 17053114-0012-0000-0000-000005410216 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17053114-0013-0000-0000-000018ABBFC0 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-31_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1705310264 X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00633.txt.bz2 On Tue, May 30 2017, Simon Marchi wrote: > I went over the patches that Yao hasn't replied on, namely 13, 14, 16, 17 > and 19, it all looks good to me (note the little comment on #17). Since > it's some tricky code, I wasn't always able to convince myself of the > correctness by just looking at it. But I went through the test cases by > hand, when applicable, and it gives me enough confidence that the code is > correct (or at least more correct than the current code :)). Thanks a lot for looking at this! > I'm not sure I like the merge of the two functions, already scary by > themselves, in one scarier monster, but I understand the downsides of > having two separate functions, so I'm ok to go with it. Yeah, it's a trade-off. > I'll let Yao decide if he wants to go himself through the remaining > patches. OK, I guess I'll wait a few more days for further feedback from Yao (or others). -- Andreas