Re: [RFC/RFA] add struct parse_context to all command functions

Ulrich Weigand
2008-10-24T13:01:21Z

Tom Tromey wrote:

> Thanks. The appended tries to fix this. I took a behavior-preserving
> approach. I looked at all the val_print-like calls. If the code
> before the patch passed 'deref_ref' to such a call, I ignored it.
> Otherwise I made a copy of the options and set deref_ref
> appropriately.
>
> In some cases I suspect the previous code is really a "don't care" and
> we could just pass through the options. But, I think that would be
> better done by someone more familiar with each call site than I am.

Agreed.

> I'll start testing this and writing the ChangeLog entry.

Thanks! The patch looks good to me now, so if testing goes well,
this is OK.

Bye,
Ulrich

--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com