Re: [RFC/RFA] add struct parse_context to all command functions

Tom Tromey
2008-10-22T20:15:07Z

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> I think it will depend on each global. For the current_language and
Joel> the input_radix, my goal is to have it used only from the command line
Joel> loop that calls the command functions.

Though there is a little wart, namely that the set and show commands
must refer to the globals directly.

Joel> I will wait another couple of days to see how people react, but it
Joel> seems at this point that everyone was OK with approach (1), where
Joel> I do the transition all in one go. And since Tom was the lead
Joel> "questioner" of this change, I'd like to mention that my understanding
Joel> is that Tom understands the benefits of adding the extra parameter,
Joel> given the above explaination. Tom, please yell if I misunderstood you!

I still think the benefits are mild, at best, but I don't want to stop
your gusto. I don't think this change will make gdb worse.

Tom