From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24543 invoked by alias); 20 Apr 2009 17:09:30 -0000 Received: (qmail 24387 invoked by uid 22791); 20 Apr 2009 17:09:29 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 20 Apr 2009 17:09:23 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n3KH9Cws001978; Mon, 20 Apr 2009 13:09:12 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n3KH9Bi2031855; Mon, 20 Apr 2009 13:09:11 -0400 Received: from opsy.redhat.com (vpn-12-214.rdu.redhat.com [10.11.12.214]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n3KH9AmH021782; Mon, 20 Apr 2009 13:09:10 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 83DFA37829A; Mon, 20 Apr 2009 11:09:09 -0600 (MDT) To: Andreas Schwab Cc: Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: NAT_FILE set incorrectly in gdb/Makefile References: <838wlwii4o.fsf@gnu.org> From: Tom Tromey Reply-To: tromey@redhat.com Date: Mon, 20 Apr 2009 17:09:00 -0000 In-Reply-To: (Andreas Schwab's message of "Sun\, 19 Apr 2009 23\:35\:05 +0200") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00516.txt.bz2 >>>>> "Andreas" == Andreas Schwab writes: Andreas> 2009-04-19 Andreas Schwab Andreas> * configure.ac: Only postprocess Makefile when it has just been Andreas> generated; avoid changequote. This all seems like overkill to get a single variable that is only used (AFAICT) in the TAGS rule. Couldn't we just compute the real value in the Makefile somehow, rather than a rewrite? But, given how minor this is, if you'd rather move forward this way, then this patch is ok if it works. Tom