From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2567 invoked by alias); 8 Jun 2009 22:39:24 -0000 Received: (qmail 2557 invoked by uid 22791); 8 Jun 2009 22:39:23 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 08 Jun 2009 22:39:17 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n58MbFdp010452; Mon, 8 Jun 2009 18:37:15 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n58MbESP018005; Mon, 8 Jun 2009 18:37:14 -0400 Received: from opsy.redhat.com (vpn-13-47.rdu.redhat.com [10.11.13.47]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n58MbDWY029897; Mon, 8 Jun 2009 18:37:13 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id B9DD2486A3; Mon, 8 Jun 2009 16:37:12 -0600 (MDT) To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: Move the multi-forks support to the generic multi-inferiors support. References: <200905310013.38916.pedro@codesourcery.com> <200906061707.21594.pedro@codesourcery.com> From: Tom Tromey Reply-To: Tom Tromey Date: Mon, 08 Jun 2009 22:39:00 -0000 In-Reply-To: <200906061707.21594.pedro@codesourcery.com> (Pedro Alves's message of "Sat\, 6 Jun 2009 17\:07\:20 +0100") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00192.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Tom> How about this? It adds the column headings and prints something when Tom> there are no inferiors. Pedro> This is fine with me, thanks, but, Pedro> are you planning on doing something similar to "info threads" Pedro> output? I wasn't planning to. Really I just wanted to get column headers for the otherwise-obscure "info inferiors" columns... Pedro> IMO, both these commands should be consistent. In that case, you Pedro> may have an issue with MI, as it calls print_thread_info --- I don't Pedro> know if using a table instead of a list changes MI output. I think it does, so changing it would not be ok. Pedro> (I was a bit surprised to (re-)find that MI doesn't use Pedro> print_inferior) Naughty. Though at a quick glance I didn't see where MI does any printing of the inferiors...? In this case I think the patch is ok anyway -- an error in "info threads" does not, IMO, imply that we should propagate the mistake to other commands. Let me know what you think of this, I won't install the patch if you feel differently. Tom