From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26725 invoked by alias); 21 Dec 2009 21:55:27 -0000 Received: (qmail 26717 invoked by uid 22791); 21 Dec 2009 21:55:26 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Dec 2009 21:55:18 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nBLLtHwa028265 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 21 Dec 2009 16:55:17 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nBLLtGZq017639; Mon, 21 Dec 2009 16:55:16 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id nBLLtFod001255; Mon, 21 Dec 2009 16:55:16 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 3CBB63781B0; Mon, 21 Dec 2009 14:55:15 -0700 (MST) From: Tom Tromey To: Sami Wagiaalla Cc: gdb-patches@sourceware.org Subject: Re: [patch 2/2] Perform a namespace lookup at every block level References: <4A57512A.7090208@redhat.com> <20090710194949.GA2064@caradoc.them.org> <4A5B68A4.30006@redhat.com> <4A68B91D.2080206@redhat.com> <4A8B0FD9.7010603@redhat.com> <4AA14648.7090600@redhat.com> <4AE09A10.9040703@redhat.com> <4B019120.7090504@redhat.com> <4B0C3011.4080000@redhat.com> Reply-To: tromey@redhat.com Date: Mon, 21 Dec 2009 21:55:00 -0000 In-Reply-To: <4B0C3011.4080000@redhat.com> (Sami Wagiaalla's message of "Tue, 24 Nov 2009 14:12:17 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-12/txt/msg00329.txt.bz2 >>>>> "Sami" == Sami Wagiaalla writes: Sami> Updating patch because of changes in patch 1/2 Sami> 2009-11-16 Sami Wagiaalla Sami> * cp-namespace.c (cp_lookup_symbol_namespace): Added Sami> search_parent argument. Sami> (cp_add_using): Initialize 'searched' field. Sami> (cp_copy_usings): Copy searched field. Sami> * cp-support.h: Add 'searched' field to using_direct struct. Sami> (cp_lookup_symbol_imports): Ditto. Sami> * cp-namespace.c (cp_lookup_symbol_imports): Ditto. Sami> Perform recursive search. Sami> Implement non parent search. Sami> * valops.c (value_maybe_namespace_elt): Updated. This is nearly ok. Note that the patch got a little mangled, and this resubmission was missing the changes in testsuite/. Sami> 2009-11-16 Sami Wagiaalla Sami> * gdb.cp/namespace-stress.exp: New test. Sami> * gdb.cp/namespace-stress.cc: New test program. Sami> * gdb.cp/namespace-recursive.exp: New test. Sami> * gdb.cp/namespace-recursive.cc: New test program. Sami> * gdb.cp/namespace-stress.exp: New test. Sami> * gdb.cp/namespace-stress.cc: New test program. We're mostly following 8.3 rules, so I would suggest renaming these to "ns-*". Also, in an archer fix you had namespace-stress-declaration... what happened to that? The corresponding code patch seems to include reset_directive_searched: http://sourceware.org/ml/archer-commits/2009-q4/msg00094.html Speaking of which, reset_directive_searched is not mentioned in the ChangeLog. Tom