Re: [RFA] defs.h: Define GDB_DEFAULT_TARGET_[WIDE_]CHARSET for Cygwin and MingW builds

Tom Tromey
2010-03-01T19:25:58Z

>>>>> "Corinna" == Corinna Vinschen <vinschen@redhat.com> writes:

Tom> I think the documentation for these functions (in charset.h) should
Tom> mention the expected lifetime of the arguments.

Corinna> I don't understand. What do you mean by "expected lifetime"?!?

The argument string must not be freed by the caller.

Tom> This seems to introduce an ordering dependency between _initialize
Tom> functions. My understanding is that we don't allow this.

Corinna> It's just a default. The default of UTF-32 breaks wide char
Corinna> support for UTF-16 targets. A native Cygwin or MingW GDB
Corinna> should have a sane default for the target charsets. That's all
Corinna> I'm trying to accomplish.

Yes, I understand. The problem here is that if the init functions are
ordered one way, then your patch installs one default, but if they are
ordered another way, then your patch installs a different default.

Personally, I think that, given the existing nl_langinfo code (and
worse, Solaris hack) in _initialize_charset, it would be fine to add
some Cygwin change here. However, I won't approve a patch like that
over Daniel's objections.

Tom