Re: [PING] [RFA-v3] Allow explicit 16 or 32 char in 'x /s'

Tom Tromey
2010-04-21T22:49:34Z

>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:

Pierre> Tom,
Pierre> would you have some time to
Pierre> take again a look at this?

This looks pretty good. A couple nits and it is ok.

>> + /* Multi-byte character types. */

I think it is more clear to describe these as "wide" character types.
I have usually seen "multi-byte" used synonymously with "variable length".

This comment appears twice.

>> + The case of strings is handled n decode_format, only explicit

Typo, s/n/in/

Ok with those changes. Thanks.

Tom