From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19568 invoked by alias); 7 May 2010 17:45:14 -0000 Received: (qmail 19559 invoked by uid 22791); 7 May 2010 17:45:14 -0000 X-SWARE-Spam-Status: No, hits=-5.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 07 May 2010 17:45:10 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o47Hj5gt029845 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 7 May 2010 13:45:05 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o47Hj4wn016987; Fri, 7 May 2010 13:45:04 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o47Hj32Z016858; Fri, 7 May 2010 13:45:03 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id F14BA378183; Fri, 7 May 2010 11:45:02 -0600 (MDT) From: Tom Tromey To: "Pierre Muller" Cc: "'Jan Kratochvil'" , Subject: Re: [RFA] PR 11530: Fix and test case References: <001b01cae7e5$f46d47d0$dd47d770$@muller@ics-cnrs.unistra.fr> <20100430081959.GB12043@host0.dyn.jankratochvil.net> <15700.946111656$1272633144@news.gmane.org> <28104.8831450336$1273095904@news.gmane.org> Reply-To: tromey@redhat.com Date: Fri, 07 May 2010 17:45:00 -0000 In-Reply-To: <28104.8831450336$1273095904@news.gmane.org> (Pierre Muller's message of "Wed, 5 May 2010 23:44:47 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00192.txt.bz2 >>>>> "Pierre" == Pierre Muller writes: %om> That is interesting. Why does it work in one case but not the other? Pierre> for the first test 'p a.i' Pierre> gdb calls search_struct_field, Pierre> which has already some code (around line 1842) Pierre> to cope for unnamed fields. Pierre> There was no equivalent in the lookup_struct_elt_type Pierre> function. Thanks. Pierre> By the way, the search_struct_field function Pierre> also allows a union called "else" to be searched. Pierre> Should this also be inserted into lookup_struct_elt_type Pierre> or is this only a left over from Chill language? I was not even aware of this case. I have no idea what it is for. I suppose that's the danger of putting language-specific code into a generic function... Tom