From: Tom Tromey <tromey@redhat.com>
To: Brad Roberts <braddr@puremagic.com>
Cc: gdb-patches@sourceware.org
Subject: Re: patch for crash in d-lang.c's demangler
Date: Wed, 11 Aug 2010 01:52:00 -0000 [thread overview]
Message-ID: <m3sk2l9aqd.fsf@fleche.redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1008101614150.23754@slice-2.puremagic.com> (Brad Roberts's message of "Tue, 10 Aug 2010 16:15:28 -0700 (PDT)")
>>>>> "Brad" == Brad Roberts <braddr@puremagic.com> writes:
Brad> Agreed. Your patch looks good. I feel guilty about not
Brad> contributing a unit test to cover this case, so I shouldn't poke
Brad> you about not adding one either, but if you feel like feeling that
Brad> guilty... :)
:)
I think it would be good to have test cases for this code, but I'm not
in a good position to write them -- I don't know D.
I'll commit this patch tomorrow with a suitable ChangeLog entry.
Tom
next prev parent reply other threads:[~2010-08-11 1:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-01 21:10 Brad Roberts
2010-08-10 22:17 ` Tom Tromey
2010-08-10 23:15 ` Brad Roberts
2010-08-11 1:52 ` Tom Tromey [this message]
2010-08-11 15:41 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3sk2l9aqd.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=braddr@puremagic.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox