From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12864 invoked by alias); 3 Feb 2011 21:42:16 -0000 Received: (qmail 12848 invoked by uid 22791); 3 Feb 2011 21:42:15 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Feb 2011 21:42:11 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id p13Lg9t9009332 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 3 Feb 2011 16:42:09 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p13Lg9WB005049; Thu, 3 Feb 2011 16:42:09 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p13Lg8Ok028554; Thu, 3 Feb 2011 16:42:08 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 39BF33784E1; Thu, 3 Feb 2011 14:42:08 -0700 (MST) From: Tom Tromey To: sami wagiaalla Cc: gdb-patches@sourceware.org Subject: Re: [patch] Support inferior events in python References: <4D2342A2.7060102@redhat.com> <4D34AF3F.4090006@redhat.com> <4D39FFFD.80304@redhat.com> <4D49C69A.20401@redhat.com> <4D4ADA8A.40507@redhat.com> Date: Thu, 03 Feb 2011 21:42:00 -0000 In-Reply-To: <4D4ADA8A.40507@redhat.com> (sami wagiaalla's message of "Thu, 03 Feb 2011 11:40:42 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00052.txt.bz2 >>>>> "Sami" == sami wagiaalla writes: Sami> Added. I also, documented StopEvent. In events which inherit from Sami> others I added a statement asking the reader to refer to the Sami> parent. Do you think that is enough, or should the inherited Sami> attributes be restated ? I think it is sufficient to mention the superclass. Sami> +int Sami> +emit_stop_event (struct bpstats *bs, enum target_signal stop_signal) Sami> +{ Sami> + PyObject *stop_event_obj = NULL; /* Appease GCC warning. */ Sami> + Sami> + if (evregpy_no_listeners_p (gdb_py_events.stop)) Sami> + return 0; Sami> + if (bs && bs->breakpoint_at Sami> + && bs->breakpoint_at->type == bp_breakpoint) I think this logic is too restrictive. What if we change what breakpoints are reflected to Python? That is, I think the check for bp_breakpoint should be removed. Instead, you could just have it check ->py_bp_object. But if you are doing that you should either rearrange, or just get rid of gdbpy_breakpoint_from_bpstats, to either preserve the abstraction or remove it. Sami> + PyObject *breakpoint = gdbpy_breakpoint_from_bpstats (bs); Sami> + if (breakpoint != NULL) Sami> + stop_event_obj = Sami> + create_breakpoint_event_object (breakpoint); Sami> + if (!stop_event_obj) Sami> + goto fail; This could result in a "fail" without an error being set. But the above change should eliminate that. Sami> +PyObject * Sami> +create_thread_event_object (PyTypeObject *py_type) Sami> +{ Sami> + PyObject *thread_event_obj = create_event_object (py_type); Sami> + PyObject *thread = get_event_thread(); Missing space. Sami> + Sami> + if (!thread_event_obj || !thread) Sami> + goto fail; You have to do error checks after each Python call, you can't batch them. Either: create_event_object can fail, in which case it is not ok to call get_event_thread on failure; or, create_event_object can return NULL but not set a Python exception, in which case you must set one explicitly. Tom