From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] C++ operators do not resolve through typedefs
Date: Fri, 18 Feb 2011 18:40:00 -0000 [thread overview]
Message-ID: <m3sjvlxl5l.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20110218155751.GA3139@host1.dyn.jankratochvil.net> (Jan Kratochvil's message of "Fri, 18 Feb 2011 16:57:51 +0100")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
The whole patch looks good to me.
Jan> * valarith.c (unop_user_defined_p): Resolve also TYPE_CODE_TYPEDEF.
The formulation of this check in binop_types_user_defined_p is simpler,
not involving a loop:
type1 = check_typedef (type1);
if (TYPE_CODE (type1) == TYPE_CODE_REF)
type1 = check_typedef (TYPE_TARGET_TYPE (type1));
[...]
return (TYPE_CODE (type1) == TYPE_CODE_STRUCT [...]
Tom
next prev parent reply other threads:[~2011-02-18 18:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-18 16:00 Jan Kratochvil
2011-02-18 18:40 ` Tom Tromey [this message]
2011-02-18 19:44 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3sjvlxl5l.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox