From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13881 invoked by alias); 17 Mar 2011 09:37:55 -0000 Received: (qmail 13873 invoked by uid 22791); 17 Mar 2011 09:37:55 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 17 Mar 2011 09:37:47 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2H9bkqG018703 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 17 Mar 2011 05:37:46 -0400 Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p2H9bj6k027948; Thu, 17 Mar 2011 05:37:45 -0400 From: Phil Muldoon To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [python] [patch] Add is_valid to several classes References: Reply-to: pmuldoon@redhat.com X-URL: http://www.redhat.com Date: Thu, 17 Mar 2011 12:19:00 -0000 In-Reply-To: (Tom Tromey's message of "Wed, 16 Mar 2011 10:42:45 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00889.txt.bz2 Tom Tromey writes: > Then you don't need the new macros, either. > > The rest looks good to me. > > Tom Eli Zaretskii writes: >> >> So how about this wording: >> This method is also made available to the Python iterator object that @code{gdb.Block} provides in iteration context and via the Python @code{iter} built-in function. > > This is fine, thanks. Committed with all requested changes. Thanks. Cheers Phil