From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3039 invoked by alias); 1 Nov 2011 17:53:49 -0000 Received: (qmail 3030 invoked by uid 22791); 1 Nov 2011 17:53:48 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Nov 2011 17:53:23 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pA1HrGQU017746 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 1 Nov 2011 13:53:19 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pA1HErNY029108; Tue, 1 Nov 2011 13:14:53 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pA1HEpUB025798; Tue, 1 Nov 2011 13:14:51 -0400 From: Tom Tromey To: Meador Inge Cc: pmuldoon@redhat.com, gdb-patches@sourceware.org Subject: Re: [python] [patch] PR python/13345 References: <4EAFFCEB.6040401@codesourcery.com> Date: Tue, 01 Nov 2011 17:53:00 -0000 In-Reply-To: <4EAFFCEB.6040401@codesourcery.com> (Meador Inge's message of "Tue, 01 Nov 2011 09:06:35 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00021.txt.bz2 >>>>> "Meador" == Meador Inge writes: Meador> On 10/31/2011 10:51 AM, Phil Muldoon wrote: >> This patch fixes a case where the tilde (~) command was being passed to >> Python via the "source" command. Python does not understand what to do >> with a tilde, so we have to expand it first. Meador> While I can't give an OK, I did review this and was able to reproduce Meador> the stated problem and the patch fixes it. So, LGTM. What about Meador> a test case, though? You could construct a relative path to a Meador> test directory from '~/'. I think in this case it is ok not to have a test. But if you want to write one it would be fine by me. It would have to be xfail'd if not under $HOME. Tom