From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15522 invoked by alias); 6 Dec 2011 20:40:47 -0000 Received: (qmail 15507 invoked by uid 22791); 6 Dec 2011 20:40:46 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 06 Dec 2011 20:40:29 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pB6KduY7010188 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 6 Dec 2011 15:39:56 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id pB6KdtoW018441; Tue, 6 Dec 2011 15:39:55 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pB6Kdi0U028471; Tue, 6 Dec 2011 15:39:45 -0500 From: Tom Tromey To: iam ahal Cc: Doug Evans , gdb-patches@sourceware.org, eliz@gnu.org, pmuldoon@redhat.com, brobecker@adacore.com, pedro@codesourcery.com, drow@false.org, jan.kratochvil@redhat.com Subject: Re: [patch] GDB 7.2: new feature for "backtrace" that cuts path to file (remain filename) References: <20110627160029.GF20676@adacore.com> <834o33qlm9.fsf@gnu.org> <83bowq6x7f.fsf@gnu.org> Date: Tue, 06 Dec 2011 20:40:00 -0000 In-Reply-To: (iam ahal's message of "Sun, 4 Dec 2011 18:52:19 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00202.txt.bz2 >>>>> "iam" == iam ahal writes: iam> Sorry for a late response, unfortunately, I've been busy at work. No problem. Thanks for following up. iam> +static const char filename_display_without_comp_directory[] = "without-compilation-directory"; Just to be clear, the patch is contingent on the naming discussion that is taking place. iam> +get_filename_display_from_sal (struct symtab_and_line *sal) How about const struct symtab_and_line *? iam> + else if (filename_display_string == filename_display_without_comp_directory iam> + && dirname && dlen && dlen <= strlen (filename) iam> + && !filename_ncmp (filename, dirname, dlen)) The indentation here looks wrong. The "&&" should line up underneath "filename_display_string". iam> + { iam> + const char *start = filename + dlen; iam> + const char *result = start; iam> + while (IS_DIR_SEPARATOR (*result)) Blank line between declarations and code. The rest looks reasonable to me. Thanks again. Tom