Re: [PATCH v2] Remove duplicated include in gdb directory

Tom Tromey
2014-01-06T16:37:30Z

>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:

Sergio> Thanks for the patch, Honggyu. I believe you have tested it by
Sergio> building GDB with --enable-targets=all, right?

That ordinarily would not be quite sufficient since this patch also
touches *-nat parts. However, reading the patch I think it is obviously
correct. None of the removed includes are "tricky" ones and the only
odd case I saw (the osdata.c change) really is correct.

Sergio> It needs a ChangeLog (mechanical), and it seems to be simple enough to
Sergio> be committed without needing a copyright assignment (I don't see your
Sergio> name in the MAINTAINERS file).

Agreed on both counts.

Sergio> Other than that, let's wait for some maintainer to give the
Sergio> green light.

You have it.

Tom