From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9061 invoked by alias); 12 Apr 2014 19:50:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9051 invoked by uid 89); 12 Apr 2014 19:50:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pb0-f50.google.com Received: from mail-pb0-f50.google.com (HELO mail-pb0-f50.google.com) (209.85.160.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 12 Apr 2014 19:50:15 +0000 Received: by mail-pb0-f50.google.com with SMTP id md12so6700984pbc.23 for ; Sat, 12 Apr 2014 12:50:13 -0700 (PDT) X-Received: by 10.67.30.168 with SMTP id kf8mr35238596pad.84.1397332213892; Sat, 12 Apr 2014 12:50:13 -0700 (PDT) Received: from seba.sebabeach.org.gmail.com (173-13-178-53-sfba.hfc.comcastbusiness.net. [173.13.178.53]) by mx.google.com with ESMTPSA id ek2sm23679507pbd.30.2014.04.12.12.50.12 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 12 Apr 2014 12:50:13 -0700 (PDT) From: Doug Evans To: Andy Wingo Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 8/9] Remove useless Guile SMOB marking functions References: <1397060028-18158-1-git-send-email-wingo@igalia.com> <1397060028-18158-9-git-send-email-wingo@igalia.com> Date: Sat, 12 Apr 2014 19:50:00 -0000 In-Reply-To: <1397060028-18158-9-git-send-email-wingo@igalia.com> (Andy Wingo's message of "Wed, 9 Apr 2014 18:13:47 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00242.txt.bz2 Andy Wingo writes: > * gdb/guile/scm-breakpoint.c: > * gdb/guile/scm-exception.c: > * gdb/guile/scm-iterator.c: > * gdb/guile/scm-objfile.c: > * gdb/guile/scm-pretty-print.c: > * gdb/guile/scm-symtab.c: > * gdb/guile/scm-type.c: > * gdb/guile/scm-value.c: Remove useless SMOB mark functions -- the SMOB > data for all of these is allocated using scm_gc_malloc, so it is > automatically marked. > --- > gdb/guile/scm-breakpoint.c | 14 -------------- > gdb/guile/scm-exception.c | 12 ------------ > gdb/guile/scm-iterator.c | 13 ------------- > gdb/guile/scm-objfile.c | 14 -------------- > gdb/guile/scm-pretty-print.c | 29 ----------------------------- > gdb/guile/scm-symtab.c | 11 ----------- > gdb/guile/scm-type.c | 11 ----------- > gdb/guile/scm-value.c | 13 ------------- > 8 files changed, 117 deletions(-) Time for some overdue review of the Guile docs, especially the section on smobs ... Blech! This is ok with the requisite changelog corrections.