From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86661 invoked by alias); 27 May 2015 04:43:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 86648 invoked by uid 89); 27 May 2015 04:43:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pd0-f172.google.com Received: from mail-pd0-f172.google.com (HELO mail-pd0-f172.google.com) (209.85.192.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 27 May 2015 04:43:13 +0000 Received: by pdfh10 with SMTP id h10so108663093pdf.3 for ; Tue, 26 May 2015 21:43:11 -0700 (PDT) X-Received: by 10.66.145.133 with SMTP id su5mr54482469pab.114.1432701791661; Tue, 26 May 2015 21:43:11 -0700 (PDT) Received: from seba.sebabeach.org.gmail.com (173-13-178-53-sfba.hfc.comcastbusiness.net. [173.13.178.53]) by mx.google.com with ESMTPSA id pj4sm8876970pbb.20.2015.05.26.21.43.10 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 May 2015 21:43:10 -0700 (PDT) From: Doug Evans To: Keith Seitz Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH v4 6/9] Explicit locations: introduce explicit locations References: <20150507180523.19629.77846.stgit@valrhona.uglyboxes.com> <20150507180559.19629.88488.stgit@valrhona.uglyboxes.com> <555A480B.9050200@redhat.com> <555BB47E.9060500@redhat.com> <555BB53F.8040307@redhat.com> <555BB5DF.90906@redhat.com> <555BB741.4050608@redhat.com> Date: Wed, 27 May 2015 04:43:00 -0000 In-Reply-To: <555BB741.4050608@redhat.com> (Keith Seitz's message of "Tue, 19 May 2015 15:20:49 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00647.txt.bz2 Keith Seitz writes: > On 05/19/2015 03:14 PM, Pedro Alves wrote: >> On 05/19/2015 11:12 PM, Keith Seitz wrote: >>> On 05/19/2015 03:09 PM, Pedro Alves wrote: >>> >> OK, as long as >> >> b -source 'file with spaces -line 10' -line 20 >> >> works as expected (might be worth it of a test), the point is >> moot then. > > I think it does what is expected: > > (gdb) b -source 'file with spaces -line 10' -line 20 > No source file named file with spaces -line 10. This error message needs to better delineate the file name. One could either put it in quotes (and escape internal quotes), or change it to something like: No such source file: file with spaces -line 10. > I'll add a test if one is missing. These "with spaces" tests appear in > ls-errs.exp and can be obscured by the fact that they test the parsing > by generating errors. I'm still really uneasy with supporting b -source file with spaces -line 20 This is intended to be the low-level access to specifying locations. Low level APIs shouldn't be too concerned with easing typing. It's easier to relax restrictions than impose them after the fact. Can we require such files to be quoted today, and then later relax the restriction if there's a compelling reason to do so?