From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109983 invoked by alias); 23 Aug 2015 00:29:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109974 invoked by uid 89); 23 Aug 2015 00:29:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f54.google.com Received: from mail-pa0-f54.google.com (HELO mail-pa0-f54.google.com) (209.85.220.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sun, 23 Aug 2015 00:29:42 +0000 Received: by padfo6 with SMTP id fo6so32913273pad.1 for ; Sat, 22 Aug 2015 17:29:40 -0700 (PDT) X-Received: by 10.66.62.202 with SMTP id a10mr31686380pas.42.1440289780272; Sat, 22 Aug 2015 17:29:40 -0700 (PDT) Received: from seba.sebabeach.org.gmail.com (173-13-178-53-sfba.hfc.comcastbusiness.net. [173.13.178.53]) by smtp.gmail.com with ESMTPSA id rp12sm12318291pbb.65.2015.08.22.17.29.39 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 22 Aug 2015 17:29:39 -0700 (PDT) From: Doug Evans To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3 01/19] Add struct completer_data to the completion API. References: <20150806191404.32159.50755.stgit@valrhona.uglyboxes.com> <20150806191431.32159.82111.stgit@valrhona.uglyboxes.com> Date: Sun, 23 Aug 2015 00:29:00 -0000 In-Reply-To: <20150806191431.32159.82111.stgit@valrhona.uglyboxes.com> (Keith Seitz's message of "Thu, 06 Aug 2015 12:14:52 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00640.txt.bz2 Keith Seitz writes: > Differences in this revision: > > 1. Updated new completer[-related] functions reg_or_group_completer_1, > reg_or_group_completer, layout_completer, tui_reggroup_completer, > window_name_completer, focus_completer, and winheight_completer. > > --- > > This patch is largely mechanical. It modifies the completion API so > that all completion functions take a new (pointer to a) structure, > which will (eventually) be used internally by the completer to perform > completion limiting. > > gdb/ChangeLog > > * completer.c (struct completer_data): Define. > * language.h (struct language_defn) > : Add struct completer_data > to argument list. > All users updated. > * symtab.c (COMPLETION_LIST_ADD_SYMBOL): Add CDATA argument. > Update all callers. > (MCOMPLETION_LIST_ADD_SYMBOL): Likewise. > (struct add_name_data) : New field. > (default_make_symbol_completion_list_break_on_1): Initialize > the above new field. > (struct add_partial_filename_data) : New field. > (make_source_files_completion_list): Initialize the above new > field. LGTM.