From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88197 invoked by alias); 18 Sep 2015 04:48:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88156 invoked by uid 89); 18 Sep 2015 04:48:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f52.google.com Received: from mail-pa0-f52.google.com (HELO mail-pa0-f52.google.com) (209.85.220.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 18 Sep 2015 04:48:42 +0000 Received: by pacfv12 with SMTP id fv12so40112798pac.2 for ; Thu, 17 Sep 2015 21:48:40 -0700 (PDT) X-Received: by 10.68.235.99 with SMTP id ul3mr4977582pbc.138.1442551720924; Thu, 17 Sep 2015 21:48:40 -0700 (PDT) Received: from seba.sebabeach.org.gmail.com (173-13-178-53-sfba.hfc.comcastbusiness.net. [173.13.178.53]) by smtp.gmail.com with ESMTPSA id g5sm6299203pat.21.2015.09.17.21.48.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Sep 2015 21:48:40 -0700 (PDT) From: Doug Evans To: Sandra Loosemore Cc: Eli Zaretskii , Subject: Re: [patch, testsuite] check for UTF-32 target wide charset support in gdb.base/wchar.exp References: <55FA325D.1020207@codesourcery.com> <8361397hwd.fsf@gnu.org> <55FA4CB5.4010802@codesourcery.com> Date: Fri, 18 Sep 2015 04:48:00 -0000 In-Reply-To: <55FA4CB5.4010802@codesourcery.com> (Sandra Loosemore's message of "Wed, 16 Sep 2015 23:16:37 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00438.txt.bz2 Sandra Loosemore writes: > On 09/16/2015 11:07 PM, Eli Zaretskii wrote: >>> Date: Wed, 16 Sep 2015 21:24:13 -0600 >>> From: Sandra Loosemore >>> >>> If GDB is configured without ICONV support, the target wide charset >>> defaults to "ISO-8859-1" (which isn't even a wide charset), and all the >>> wide strings in this test print as gibberish. Otherwise, GDB seems to >>> think the default is "auto; currently UTF-32", so let's make the >>> dependency on UTF-32 explicit here and bail out if it's not available. >> >> Why UTF-32, hard-coded? Why not allow also UTF-16, for example? > > It looked to me like the default target wide charset is UTF-32 if you > don't pick one explicitly. Since the test as currently written > doesn't, the patterns the .exp file is trying to match must assume the > default target wide charset, and not some other wide charset that > might happen to be supported. > > If I'm confused and the default charset might not always be UTF-32 if > ICONV is present, how about changing the testcase to bail if it sees > the default wide charset is ISO-8859-1? That means either ICONV is > not present or GDB's default is otherwise wrongly configured. The question I have is what's the intent behind PHONY_ICONV? [The fact that it apparently tries to provide some minimal wide char support but defines GDB_DEFAULT_TARGET_WIDE_CHARSET as "ISO-8859-1" seems like a bug to me.] Is it intended that it provide some minimal wide char support? And if so, my preference would be to keep the test if it's easy.