From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85600 invoked by alias); 13 Feb 2017 17:03:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 85587 invoked by uid 89); 13 Feb 2017 17:03:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.3 required=5.0 tests=AWL,BAYES_50,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*i:sk:1486989, UD:py-record.c, py-record.c, pyrecordc X-HELO: mail-oi0-f66.google.com Received: from mail-oi0-f66.google.com (HELO mail-oi0-f66.google.com) (209.85.218.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 13 Feb 2017 17:03:17 +0000 Received: by mail-oi0-f66.google.com with SMTP id w144so8271062oiw.1 for ; Mon, 13 Feb 2017 09:03:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ULcEcE1q+0EXW147TLKGBYyKlqMOvvT1FDHA10j5xg8=; b=ThIemZARIOvDyrMqsyZL/R51DF5VVBWfkNSw15EFBEU/aK16HJ62pJ+BXZ7j5KkMeR efLlJGfGvwjz9oS4tAGrCF+3dXvrDb9yeD7qh4hpWPD0QTcufGgZ/6f91pb480dhOpCR FaSMWDKE4aK9nqBKaD0GRukCEPEKZ2JawIHJq4WEa5VPjCzFHSL0x5xEEhAyx9uXeG2F OGl3QHjaQMbfDD1qMSmd3Nzg3BNGe5Q0zJIvdnCvHY2pxCrN9ScPrfcDVsSQgQy5Mo3R c+veNyNsw3RyMCIFrOF4JJrU1vwInVyDCfa80kl+8ZdQR8b4406khbtCOpAujvcpgxQ7 Wf8g== X-Gm-Message-State: AMke39nOHPs4CXbEwllDHQPr6PEGkJUvUN885YjCT62aS6kxHIhC2bV6K7ZCKcS9xQErig== X-Received: by 10.99.158.2 with SMTP id s2mr27669512pgd.116.1487005395682; Mon, 13 Feb 2017 09:03:15 -0800 (PST) Received: from seba.sebabeach.org.gmail.com (173-13-178-53-sfba.hfc.comcastbusiness.net. [173.13.178.53]) by smtp.gmail.com with ESMTPSA id x15sm15850752pgo.56.2017.02.13.09.03.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 13 Feb 2017 09:03:15 -0800 (PST) From: Doug Evans To: Tim Wiederhake Cc: gdb-patches@sourceware.org, markus.t.metzger@intel.com, palves@redhat.com Subject: Re: [PATCH v6 7/9] python: Implement btrace Python bindings for record history. References: <1486989450-11313-1-git-send-email-tim.wiederhake@intel.com> <1486989450-11313-8-git-send-email-tim.wiederhake@intel.com> Date: Mon, 13 Feb 2017 17:03:00 -0000 In-Reply-To: <1486989450-11313-8-git-send-email-tim.wiederhake@intel.com> (Tim Wiederhake's message of "Mon, 13 Feb 2017 13:37:28 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00347.txt.bz2 Tim Wiederhake writes: > This patch implements the gdb.Record Python object methods and fields for > record target btrace. Also, implement a stub for record target full. > > 2017-02-13 Tim Wiederhake > > gdb/ChangeLog: > > * Makefile.in (SUBDIR_PYTHON_OBS): Add py-record-btrace.o, > py-record-full.o. > (SUBDIR_PYTHON_SRCS): Add py-record-btrace.c, py-record-full.c. > * python/py-record-btrace.c, python/py-record-btrace.h, > python/py-record-full.c, python/py-record-full.h: New file. > * python/py-record.c: Add include for py-record-btrace.h and > py-record-full.h. > (recpy_method, recpy_format, recpy_goto, recpy_replay_position, > recpy_instruction_history, recpy_function_call_history, recpy_begin, > recpy_end): Use functions from py-record-btrace.c and py-record-full.c. > * python/python-internal.h (PyInt_FromSsize_t, PyInt_AsSsize_t): > New definition. > (gdbpy_initialize_btrace): New export. > * python/python.c (_initialize_python): Add gdbpy_initialize_btrace. LGTM