From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93361 invoked by alias); 20 Mar 2017 17:57:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93343 invoked by uid 89); 20 Mar 2017 17:57:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 20 Mar 2017 17:57:19 +0000 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v2KHriFh078846 for ; Mon, 20 Mar 2017 13:57:19 -0400 Received: from e06smtp15.uk.ibm.com (e06smtp15.uk.ibm.com [195.75.94.111]) by mx0a-001b2d01.pphosted.com with ESMTP id 299yqbug9k-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 20 Mar 2017 13:57:19 -0400 Received: from localhost by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 20 Mar 2017 17:57:17 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp15.uk.ibm.com (192.168.101.145) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 20 Mar 2017 17:57:13 -0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v2KHvDIn15729078; Mon, 20 Mar 2017 17:57:13 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1FF035203F; Mon, 20 Mar 2017 16:55:39 +0000 (GMT) Received: from oc1027705133.ibm.com (unknown [9.152.212.162]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTPS id 0075152045; Mon, 20 Mar 2017 16:55:38 +0000 (GMT) From: Andreas Arnez To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix spurious FAILs with examine-backward.exp References: Date: Mon, 20 Mar 2017 17:57:00 -0000 In-Reply-To: (Pedro Alves's message of "Mon, 20 Mar 2017 17:34:06 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 x-cbid: 17032017-0020-0000-0000-000003281E5A X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17032017-0021-0000-0000-000040DF91EF Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-20_13:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703200153 X-IsSubscribed: yes X-SW-Source: 2017-03/txt/msg00343.txt.bz2 On Mon, Mar 20 2017, Pedro Alves wrote: > On 03/20/2017 05:14 PM, Andreas Arnez wrote: >> The test case examine-backward.exp issues the command "x/-s" after the end >> of the first string in TestStrings, but without making sure that this >> string is preceded by a string terminator. Thus GDB may spuriously print >> some random characters from before that string, and then the test fails. >> >> This patch assures that TestStrings is preceded by a string terminator. >> > > Agreed. Looks like I forgot to follow through with: > > https://sourceware.org/ml/gdb-patches/2016-08/msg00127.html Heh, and you even expressed exactly the same thought I had about this: "It's not strictly correct to assume that the linker places the objects consecutively, but it's probably safe in practice." > >> >> +const char Barrier[] = { >> + 0x00, >> +}; >> + > > OK with a comment. Feel free to steal mine from that url. Sure :-) Pushed with that change. Thanks, Andreas