From: Tom Tromey <tromey@redhat.com>
To: Thiago Jung Bauermann <bauerman@br.ibm.com>
Cc: Daniel Jacobowitz <drow@false.org>,
gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [RFA] Add la_getstr member to language_defn
Date: Tue, 03 Feb 2009 17:44:00 -0000 [thread overview]
Message-ID: <m3r62fjtzv.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1233665501.14735.7.camel@localhost.localdomain> (Thiago Jung Bauermann's message of "Tue\, 03 Feb 2009 10\:51\:41 -0200")
>>>>> "Thiago" == Thiago Jung Bauermann <bauerman@br.ibm.com> writes:
Tom> When would we want the latter behavior? I think perhaps la_getstr
Tom> should simply have 'void' type and then call error if read_string
Tom> returns an error.
[...]
Thiago> I don't have a strong preference. The function could always throw an
Thiago> exception on error, and the caller would then check LENGTH to see if
Thiago> something was read. I can change it to do so if you prefer it that way.
When would a caller want to use a partial result? If there is a case
where we'd want that, then the current approach used in the patch
seems ok. However, if there is no case where we'd want to do that,
then this approach is more complex without a benefit.
The reason I ask is that I noticed that the only caller of this
function -- the new Value.string method -- discards a partial result.
Tom
next prev parent reply other threads:[~2009-02-03 17:44 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-24 13:24 Thiago Jung Bauermann
2008-11-24 13:32 ` Daniel Jacobowitz
2008-11-24 14:59 ` Thiago Jung Bauermann
2008-11-24 16:19 ` Daniel Jacobowitz
2008-11-24 20:22 ` Thiago Jung Bauermann
2008-11-25 2:16 ` Daniel Jacobowitz
2008-11-25 8:53 ` Thiago Jung Bauermann
2009-01-03 2:27 ` Thiago Jung Bauermann
2009-02-02 18:42 ` Tom Tromey
2009-02-03 12:51 ` Thiago Jung Bauermann
2009-02-03 17:44 ` Tom Tromey [this message]
2009-02-04 12:37 ` Thiago Jung Bauermann
2009-02-04 19:19 ` Tom Tromey
2009-02-04 22:26 ` Thiago Jung Bauermann
2009-02-05 0:55 ` Tom Tromey
2009-02-05 12:21 ` Thiago Jung Bauermann
2009-02-05 16:01 ` Pierre Muller
2009-02-05 16:30 ` Thiago Jung Bauermann
2009-02-05 16:46 ` Tom Tromey
2009-02-05 15:55 ` Tom Tromey
2009-02-05 16:07 ` Pierre Muller
2009-02-05 16:33 ` Thiago Jung Bauermann
2009-02-05 16:46 ` Tom Tromey
2009-02-03 0:23 ` Joel Brobecker
2009-02-03 13:02 ` Thiago Jung Bauermann
2009-02-03 17:01 ` Joel Brobecker
2009-02-03 17:40 ` Tom Tromey
2009-02-05 17:01 ` Thiago Jung Bauermann
2009-02-05 23:51 ` Joel Brobecker
2008-11-24 20:03 ` Tom Tromey
2008-11-24 21:19 ` Thiago Jung Bauermann
2008-11-25 0:55 ` Tom Tromey
2008-11-25 11:27 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3r62fjtzv.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=bauerman@br.ibm.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox