From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24402 invoked by alias); 16 Apr 2009 22:49:36 -0000 Received: (qmail 24388 invoked by uid 22791); 16 Apr 2009 22:49:34 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 16 Apr 2009 22:49:28 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n3GMn4Lh005859; Thu, 16 Apr 2009 18:49:04 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n3GMn3Mw030022; Thu, 16 Apr 2009 18:49:03 -0400 Received: from opsy.redhat.com (vpn-12-173.rdu.redhat.com [10.11.12.173]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n3GMn2Hc005573; Thu, 16 Apr 2009 18:49:03 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 43CD350830B; Thu, 16 Apr 2009 16:49:02 -0600 (MDT) To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [commit/Ada] delete ada-lang.c:extract_string and use target_read_string instead References: <20090416171914.GM7557@adacore.com> <20090416224507.GM7585@adacore.com> From: Tom Tromey Reply-To: Tom Tromey Date: Thu, 16 Apr 2009 22:49:00 -0000 In-Reply-To: <20090416224507.GM7585@adacore.com> (Joel Brobecker's message of "Thu\, 16 Apr 2009 15\:45\:07 -0700") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00401.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> Yes, it is in ascii. Can I get away without doing a conversion, or Joel> would it be better if I did? The string just contains a symbol name. If it is always ascii then it is pretty safe as-is. gdb assumes that the host execution character set is ascii-compatible in several places. And, there is no validation or conversion of the character set used in the debug info. So, this isn't any worse than existing situations :-) Tom