From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5337 invoked by alias); 22 Jun 2009 18:26:43 -0000 Received: (qmail 5326 invoked by uid 22791); 22 Jun 2009 18:26:43 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 22 Jun 2009 18:26:29 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n5MIQS6T013149 for ; Mon, 22 Jun 2009 14:26:28 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n5MIQRcA006140; Mon, 22 Jun 2009 14:26:27 -0400 Received: from opsy.redhat.com (vpn-13-249.rdu.redhat.com [10.11.13.249]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n5MIQQB5030850; Mon, 22 Jun 2009 14:26:27 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 55B8B888077; Mon, 22 Jun 2009 12:26:26 -0600 (MDT) To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] Accelerate blocks sorting References: <20090622173856.GA6649@host0.dyn.jankratochvil.net> From: Tom Tromey Reply-To: tromey@redhat.com Date: Mon, 22 Jun 2009 18:26:00 -0000 In-Reply-To: <20090622173856.GA6649@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Mon\, 22 Jun 2009 19\:38\:56 +0200") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00573.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> GDB has been reported as hanging on crashed webkit. Jan> https://bugzilla.redhat.com/show_bug.cgi?id=507267 This is also http://sourceware.org/bugzilla/show_bug.cgi?id=9988 Jan> + return (BLOCK_START (b) > BLOCK_START (a)) Jan> + - (BLOCK_START (b) < BLOCK_START (a)); This expression needs parens around it, according to GNU rules. Jan> + barray = xmalloc (sizeof (*barray) * count); Jan> + back_to = make_cleanup (xfree, barray); I think you don't actually need a cleanup here, as nothing here can call error. However, if you want to leave it, that is also ok with me. This is ok with a fix to the formatting nit. Tom