From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4044 invoked by alias); 2 Nov 2010 20:31:26 -0000 Received: (qmail 3954 invoked by uid 22791); 2 Nov 2010 20:31:20 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 02 Nov 2010 20:31:15 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oA2KV7DP014781 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 2 Nov 2010 16:31:07 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id oA2KV6rK010272; Tue, 2 Nov 2010 16:31:06 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id oA2KV5RB009420; Tue, 2 Nov 2010 16:31:06 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 5E8D98880CA; Tue, 2 Nov 2010 14:22:15 -0600 (MDT) From: Tom Tromey To: Doug Evans Cc: Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: [RFA, doc RFA]: New printing module and info/disable/enable commands References: <20101101024704.6A4AA2461AF@ruffy.mtv.corp.google.com> <83r5f56611.fsf@gnu.org> Date: Tue, 02 Nov 2010 20:31:00 -0000 In-Reply-To: (Doug Evans's message of "Tue, 2 Nov 2010 10:35:04 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00050.txt.bz2 >>>>> "Doug" == Doug Evans writes: Doug> +When @value{GDBN} prints a value, it first sees if there is a pretty-printer Doug> +registered for the value's type. Actually, a printer can recognize a value based on whatever it likes, not just the value's type. Doug> +import gdb.command.pretty_printers Doug> + Doug> +gdb.command.pretty_printers.register_pretty_printer_commands() I think we should have command modules auto-register the commands on import. That way we can make __init__.py import all the command modules it finds and not worry about what functions to call to initialize. I don't think you need to change anything here, unless you really want. Phil is working on a patch in this area right now. Thanks for doing this. It looks good to me. I will try to remember to update the libstdc++ printers to (conditionally) use the new machinery when I get back. I think this will let us finally give users the ability to separately disable the iterator printers, which some folks have asked for. Tom