From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26027 invoked by alias); 1 Mar 2011 17:08:17 -0000 Received: (qmail 26019 invoked by uid 22791); 1 Mar 2011 17:08:16 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Mar 2011 17:08:07 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p21H83D3025165 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 1 Mar 2011 12:08:03 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p21H82lj019254; Tue, 1 Mar 2011 12:08:03 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p21H81Yn017277; Tue, 1 Mar 2011 12:08:02 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 3FC293785EB; Tue, 1 Mar 2011 10:08:00 -0700 (MST) From: Tom Tromey To: Thiago Jung Bauermann Cc: gdb-patches ml Subject: Re: [RFA] Fix decode_indirect to use parse_to_comma_and_eval References: <1298493740.3172.28.camel@hactar> Date: Tue, 01 Mar 2011 17:08:00 -0000 In-Reply-To: <1298493740.3172.28.camel@hactar> (Thiago Jung Bauermann's message of "Wed, 23 Feb 2011 17:42:20 -0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00032.txt.bz2 >>>>> "Thiago" == Thiago Jung Bauermann writes: Thiago> This came up in the discussion about the ranged breakpoints patch. I Thiago> needed the break-range command to accept locations of the form *PC in a Thiago> string of the form "*PC_START, *PC_END" but couldn't call Thiago> parse_breakpoint_sals because decode_indirect (called by decode_line_1) Thiago> tried to read past the comma and got confused. Ulrich mentioned that it Thiago> should stop at the comma. This patch implements that. Usually I am opposed to incompatible changes, but this one seems fairly harmless to me. It seems unlikely that anybody ever uses a "," in an expression in a linespec. Thiago> No regressions on ppc-linux and ppc64-linux. Ok? If there are no objections by Friday, please go ahead. Tom